search

awslabs / landing-zone-accelerator-on-aws

Deploy a multi-account cloud foundation to support highly-regulated workloads and complex compliance requirements.
https://aws.amazon.com/solutions/implementations/landing-zone-accelerator-on-aws/
Apache License 2.0
541 stars 431 forks source link

CodeCommit deprecated #520

Open yaolu-dtp opened 2 months ago

yaolu-dtp commented 2 months ago

Is your feature request related to a problem? Please describe. CodeCommit is deprecated. https://aws.amazon.com/blogs/devops/how-to-migrate-your-aws-codecommit-repository-to-another-git-provider/

Describe the feature you'd like Can we have instructions for using an alternative git repo?

Additional context Nil

ssennettau commented 2 months ago

Confirmed by Jeff Barr on Twitter specifically about the deprecation of CodeCommit.

This isn't just a feature request now - this change actively prevents the deployment of AWS Landing Zone Accelerator into new AWS Accounts.

EDIT: I was incorrect, the recent release of v1.9.0 enabled support for Amazon S3 for the configuration files, so LZA is still deployable for new customers. But it does not support other Git providers or SCMs, so this issue is still relevant.

snemir2 commented 2 months ago

lol. a while back i opened up a feature request to pull directly from github.
It probably would be best to integrate LZA directly with Git Hub.

n2aws commented 1 month ago

lol. a while back i opened up a feature request to pull directly from github. It probably would be best to integrate LZA directly with Git Hub.

I second this. since the main LZA code base is hosted on github already, it'd be ideal to at least support github for the configuration files too. Ideally "any git provider" would be the preference, then users can do self hosted, github, gitlab, bitbucket, etc etc.

Currently, the s3 options "works" but makes version control a pian, forcing users to either manually update the bucket OR setup their own pipeline to take the code from a git repo, package it up, and deploy it to the s3 bucket. It works, but it's not ideal IMO.

vanja-zecevic commented 6 days ago

I agree, would be much better to have native support for github, bitbucket, etc. for config files. Otherwise we will need to implement our own pipeline to pull from git to S3.

kisst commented 6 days ago

I created an LZA customisation which deploys a CFN template , contains an IAM role and using OICD it grants permission to the repository for zip upload and created a GitHub Actions which does the zip and upload to S3 . As a result my pipeline is up to date with config hosted on GH side, however this is pushed config and not pulled like the src code for LZA which also needs a GH PAT. All code is generalised so happy to share it with the public if you think it would be useful .