search

awslabs / landing-zone-accelerator-on-aws

Deploy a multi-account cloud foundation to support highly-regulated workloads and complex compliance requirements.
https://aws.amazon.com/solutions/implementations/landing-zone-accelerator-on-aws/
Apache License 2.0
562 stars 448 forks source link

feat: Export admin role and execution role for custom stackset's deployment #625

Closed allcloud-sahar-hagbi closed 3 days ago

allcloud-sahar-hagbi commented 3 weeks ago

Hi, This is a FR for deploying custom stack sets with custom admin role and custom execution role. The changes is not so much so I'm fell like there is no need to elaborate on them. Please tell me if something is missing, thx.

EDIT:

The CI has been failed due to un-updated snapshot in release v1.10.0

erwaxler commented 3 weeks ago

Hi @allcloud-sahar-hagbi, thank you for contributing to the LZA! I'll get this code reviewed by the team and let you know if there is any feedback. Thank you for your contribution!

erwaxler commented 3 days ago

Hi @allcloud-sahar-hagbi , I'm pleased to say this feature has been merged into the code base and will be included in the next major release, I will go ahead and close this PR. Thank you again for your support of the Landing Zone Accelerator!