awslabs / landing-zone-accelerator-on-aws

Deploy a multi-account cloud foundation to support highly-regulated workloads and complex compliance requirements.
https://aws.amazon.com/solutions/implementations/landing-zone-accelerator-on-aws/
Apache License 2.0
564 stars 449 forks source link

Update Subscription Lambda has insufficient privledges #646

Open richardkeit opened 1 week ago

richardkeit commented 1 week ago

Describe the bug Custom resource responsible for configuring centralised logging (kinda important function) silently fails with access denied on KMS encryption

To Reproduce global-config.yaml:

logging:
  cloudwatchLogs:
    enable: true
    encryption:
      useCMK: true
      deploymentTargets:
        organizationalUnits:
          - Root

Expected behavior No errors and log groups have encryption enabled

Please complete the following information about the solution:

Screenshots

Screenshot 2024-11-15 at 10 12 40 AM Screenshot 2024-11-15 at 10 11 54 AM

Additional context PR raised for fix, please give it some love 💚 :

PS: This feature doesn't respect the encryption value, ie it ALWAYS attempts to encrypt (from what I can see)