chore: add llrt binaries to .gitignore - Githubissues

awslabs / llrt

LLRT (Low Latency Runtime) is an experimental, lightweight JavaScript runtime designed to address the growing demand for fast and efficient Serverless applications.

Apache License 2.0

7.74k stars 342 forks source link

chore: add llrt binaries to .gitignore #308

Closed nabetti1720 closed 3 months ago

nabetti1720 commented 3 months ago

Description of changes

Adding llrt and bootstrap to .gitignore prevents accidental commits after unzipping a zip created with make release or make release-* and checking local behavior.

Checklist

[n/a] Created unit tests in tests/unit and/or in Rust for my feature if needed
[n/a] Ran make fix to format JS and apply Clippy auto fixes
[n/a] Made sure my code didn't add any additional warnings: make check
[n/a] Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

richarddavison commented 3 months ago

@nabetti1720 can you please rebase your PR, I had to rewrite commit history to remove the binary

nabetti1720 commented 3 months ago

Hi, @richarddavison. I think I have addressed this. I hope this is working out for you.