awslabs / llrt

LLRT (Low Latency Runtime) is an experimental, lightweight JavaScript runtime designed to address the growing demand for fast and efficient Serverless applications.
Apache License 2.0
8.04k stars 355 forks source link

Add rustfmt.toml to mantain format consistency #328

Closed yollotltam closed 5 months ago

yollotltam commented 6 months ago

Thid PR adds rustfmt.toml, currently the following rules were added:

There are some rules that may be convenient to run like:

I will run make fix when reviewers agree on the rules.

calavera commented 6 months ago

Those are fine by me. I usually add these because I like to keep imports ordered, but it requires running cargo fmt with nightly:

unstable_features = true
imports_granularity = "Crate"
reorder_imports = true
yollotltam commented 6 months ago

Those are fine by me. I usually add these because I like to keep imports ordered, but it requires running cargo fmt with nightly:

unstable_features = true
imports_granularity = "Crate"
reorder_imports = true

Yeah me too, I just update the PR comment with those rules.

richarddavison commented 6 months ago

LGTM but can we apply this format for all rs files in same PR? (check is failing)