feat: Improved compliance of Encoding APIs - Githubissues

awslabs / llrt

LLRT (Low Latency Runtime) is an experimental, lightweight JavaScript runtime designed to address the growing demand for fast and efficient Serverless applications.

Apache License 2.0

7.73k stars 341 forks source link

feat: Improved compliance of Encoding APIs #420

Closed nabetti1720 closed 1 week ago

nabetti1720 commented 2 weeks ago

Description of changes

Add the following methods/properties to improve the compliance of Encoding API.

TextEncoder.encoding
TextDecoder.fatal
TextDecoder.ignoreBOM
TextDecoder.encoding
TextDecoder.decode()

And the encoding_rs crate was adopted for simplicity in dealing with various labels of TextDecoder().

Checklist

[x] Created unit tests in tests/unit and/or in Rust for my feature if needed
[x] Ran make fix to format JS and apply Clippy auto fixes
[x] Made sure my code didn't add any additional warnings: make check
[x] Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nabetti1720 commented 1 week ago

Hi @richarddavison , Thank you for your always accurate reviews. All have been corrected, please confirm. :)