awslabs / mlmax

Example templates for the delivery of custom ML solutions to production so you can get started quickly without having to make too many design choices.
https://mlmax.readthedocs.io/en/latest/
Apache License 2.0
66 stars 19 forks source link

Environment module deploy.sh to support region override #52

Closed verdimrc closed 3 years ago

verdimrc commented 3 years ago

🐛 Bug report

Describe the bug

modules/environment/deploy.sh only picks the region defined in the runtime environment (env vars or ~/.aws/config entry). It does not allow user to deploy on a different region without changing their AWS CLI setup.

To reproduce

Run ./deploy.sh on a bucket in a different region that what's configured in AWS CLI.

Expected behavior

something like ./deploy.sh --region ap-southeast-2 even if ~/.aws/config defaults to ap-southeast-1. Otherwise, this can impede / introduce friction for using the same account to deploy to several regions.

System information

yihyap commented 3 years ago

Issue is fixed in #54