search

awslabs / mlmax

Example templates for the delivery of custom ML solutions to production so you can get started quickly without having to make too many design choices.
https://mlmax.readthedocs.io/en/latest/
Apache License 2.0
66 stars 19 forks source link

Feature add internet access #61

Closed yihyap closed 3 years ago

yihyap commented 3 years ago

Issue #25

Description of changes: To support internet access to EC2. Now user has the option to enable internet access.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

josiahdavis commented 3 years ago

Great progress @yihyap! Couple questions I had:

  1. It might be useful to add pre-requisites as its own section in quick start. i.e., 0) You must have KeyPair, an S3 Bucket to write to, etc...
  2. Are you planning to create step functions endpoint? If not, let's remove from diagrams.
  3. What do you think about having config accept one parameter for internet access instead of two (SageMaker + EC2)? I can't think of any situations where we would want internet access for the one and not the other.

Thanks so much!