Closed mgeisler closed 8 months ago
I don't think this is super important for us, it was just something that came up when Anh was looking at the storage trait.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.49%. Comparing base (
e4009f9
) to head (ebb0493
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues:
Addresses #81
Description of changes:
This removes the
GroupState
type from theGroupStateStorage
trait in mls-rs-uniffi. This is done for two reasons:It makes all methods on the trait consistent in the way that they take a
group_id
as the first argument.Fewer types means less boiler-plate generated by the UniFFI bindings generator (
Vec<u8>
is a built-in type in UniFFI).Call-outs:
The
EpochRecord
type stays: I don’t think we have a different way of passing in a vector of epochs IDs with their data.I could apply this change to mls-rs too, but it doesn’t seem useful there since it’s cheap and easy to create a new type in Rust.
Testing:
Updated tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.