awslabs / mls-rs

An implementation of Messaging Layer Security (RFC 9420)
Apache License 2.0
105 stars 19 forks source link

[uniffi] Remove `GroupState` type from storage trait #128

Closed mgeisler closed 8 months ago

mgeisler commented 8 months ago

Issues:

Addresses #81

Description of changes:

This removes the GroupState type from the GroupStateStorage trait in mls-rs-uniffi. This is done for two reasons:

Call-outs:

The EpochRecord type stays: I don’t think we have a different way of passing in a vector of epochs IDs with their data.

I could apply this change to mls-rs too, but it doesn’t seem useful there since it’s cheap and easy to create a new type in Rust.

Testing:

Updated tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

mgeisler commented 8 months ago

I don't think this is super important for us, it was just something that came up when Anh was looking at the storage trait.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.49%. Comparing base (e4009f9) to head (ebb0493).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #128 +/- ## ========================================== - Coverage 89.49% 89.49% -0.01% ========================================== Files 173 173 Lines 31407 31404 -3 ========================================== - Hits 28109 28106 -3 Misses 3298 3298 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.