search

awslabs / mls-rs

An implementation of Messaging Layer Security (RFC 9420)
Apache License 2.0
93 stars 18 forks source link

Fix comment regarding macro order #131

Closed stefunctional closed 6 months ago

stefunctional commented 6 months ago

Follow-up for #130.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.51%. Comparing base (d54563f) to head (985703b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #131 +/- ## ======================================= Coverage 89.51% 89.51% ======================================= Files 173 173 Lines 31450 31450 ======================================= Hits 28151 28151 Misses 3299 3299 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mgeisler commented 6 months ago

Thanks for fixing this.

It would be nice to know why this is... perhaps one of the two crates can be changed so that the order can stay the same in the two cases. It's not super important now, but I hope to look into this eventually.

stefunctional commented 6 months ago

It would be nice to know why this is

Apparently uniffi can't deal with the lifetimes in the code generated by async_trait.