search

awslabs / mls-rs

An implementation of Messaging Layer Security (RFC 9420)
Apache License 2.0
99 stars 19 forks source link

Add more context to ms rules / identity provider callbacks #204

Open mulmarta opened 1 week ago

mulmarta commented 1 week ago

Maybe useful to know more context

Call-outs

Moving GroupContext to core means making tree_hash and confirmed_transcript_hash public (there's currently a function on ExternalGroup that returns confirmed_transcript_hash anyway).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

tomleavy commented 1 week ago

@mulmarta holding off on merging this for a week or so to see if we need any non-breaking changes first

codecov-commenter commented 2 days ago

Codecov Report

Attention: Patch coverage is 93.91304% with 14 lines in your changes missing coverage. Please review.

Project coverage is 90.18%. Comparing base (0532380) to head (01da3b2).

Files with missing lines Patch % Lines
mls-rs-core/src/group/context.rs 57.89% 8 Missing :warning:
mls-rs/src/group/mls_rules.rs 55.55% 4 Missing :warning:
mls-rs-identity-x509/src/provider.rs 0.00% 1 Missing :warning:
mls-rs/src/group/message_processor.rs 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #204 +/- ## ========================================== + Coverage 90.16% 90.18% +0.02% ========================================== Files 175 176 +1 Lines 31448 31508 +60 ========================================== + Hits 28354 28417 +63 + Misses 3094 3091 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.