Closed mulmarta closed 1 week ago
@mulmarta holding off on merging this for a week or so to see if we need any non-breaking changes first
Attention: Patch coverage is 93.91304%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 90.16%. Comparing base (
9f4d07f
) to head (431ba42
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
I fixed the merge conflict (version in Cargo.toml), I think I addressed all the comments, and we waited 2 weeks. OK to merge @tomleavy ?
I fixed the merge conflict (version in Cargo.toml), I think I addressed all the comments, and we waited 2 weeks. OK to merge @tomleavy ?
Yup, I think we are good
Maybe useful to know more context
Call-outs
Moving GroupContext to core means making
tree_hash
andconfirmed_transcript_hash
public (there's currently a function on ExternalGroup that returnsconfirmed_transcript_hash
anyway).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.