awslabs / mls-rs

An implementation of Messaging Layer Security (RFC 9420)
Apache License 2.0
104 stars 19 forks source link

Improve custom proposal filtering #205

Closed mulmarta closed 2 weeks ago

mulmarta commented 2 weeks ago

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.16%. Comparing base (6d4a11a) to head (55ad632). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
mls-rs/src/group/proposal_cache.rs 95.65% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #205 +/- ## ========================================== + Coverage 90.15% 90.16% +0.01% ========================================== Files 175 175 Lines 31408 31421 +13 ========================================== + Hits 28315 28332 +17 + Misses 3093 3089 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stefunctional commented 2 weeks ago

As discussed with Marta, this change requires some care in clients so that they don't end up in a state where they cannot commit anymore. Specifically, if a client receives a custom proposal that expands to something invalid, the client cannot commit anymore until they explicitly clear their proposal cache.