Closed mulmarta closed 2 weeks ago
Attention: Patch coverage is 97.43590%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 90.16%. Comparing base (
6d4a11a
) to head (55ad632
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
mls-rs/src/group/proposal_cache.rs | 95.65% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
As discussed with Marta, this change requires some care in clients so that they don't end up in a state where they cannot commit anymore. Specifically, if a client receives a custom proposal that expands to something invalid, the client cannot commit anymore until they explicitly clear their proposal cache.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.