search

awslabs / mountpoint-s3-csi-driver

Built on Mountpoint for Amazon S3, the Mountpoint CSI driver presents an Amazon S3 bucket as a storage volume accessible by containers in your Kubernetes cluster.
Apache License 2.0
193 stars 23 forks source link

Add imagePullSecrets support #123

Closed truestory1 closed 8 months ago

truestory1 commented 8 months ago

*Issue #122

Description of changes: add imagePullSecrets support for private registries (optional)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

truestory1 commented 8 months ago

With current changes the template is rendered as

$ helm template -s templates/node.yaml . | yq '.spec.template.spec' | head -15
nodeSelector:
  kubernetes.io/os: linux
serviceAccountName: s3-csi-driver-sa
priorityClassName: system-node-critical
tolerations:
  - key: CriticalAddonsOnly
    operator: Exists
  - operator: Exists
    effect: NoExecute
    tolerationSeconds: 300
imagePullSecrets:
  - name: test-secret-name
initContainers:
  - name: install-mountpoint
    image: public.ecr.aws/mountpoint-s3-csi-driver/aws-mountpoint-s3-csi-driver:v1.1.0
...
...

where

$ cat values.yaml | grep -A1 imagePullSecrets  
imagePullSecrets:
  - name: test-secret-name

I did not add test scenario for this specific case.