awslabs / mountpoint-s3-csi-driver

Built on Mountpoint for Amazon S3, the Mountpoint CSI driver presents an Amazon S3 bucket as a storage volume accessible by containers in your Kubernetes cluster.
Apache License 2.0
153 stars 18 forks source link

Allow actions to be run for forked PRs #131

Closed truestory1 closed 4 months ago

truestory1 commented 5 months ago

Description of changes: according to https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect#adding-permissions-settings this change should fix https://github.com/awslabs/mountpoint-s3-csi-driver/actions/runs/7616759109/job/20745254205?pr=123

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

truestory1 commented 4 months ago

according to https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token "Maximum access for pull requests from public forked repositories" is read. I would close this PR. Due to security model seems it's not possible to implement this change.