awslabs / multi-model-server

Multi Model Server is a tool for serving neural net models for inference
Apache License 2.0
984 stars 230 forks source link

Explicitly terminate process in sigterm_handler #1006

Open nskool opened 1 year ago

nskool commented 1 year ago

Before or while filing an issue please feel free to join our slack channel to get in touch with development team, ask questions, find out what's cooking and more!

Issue #, if available:

Description of changes:

Just removing socket in sigterm_handler does not seem to kill the process. If a socket gets closed, the STREAM session detects the closing of connection and that should automatically kill process, however, this does not seem to work as expected and we can try explicitly terminating the process in the handler, after removing the socket.

Testing done:

To run CI tests on your changes refer README.md

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.