awslabs / multi-model-server

Multi Model Server is a tool for serving neural net models for inference
Apache License 2.0
989 stars 230 forks source link

Model name overlap not supported? #15

Closed cjolivier01 closed 6 years ago

cjolivier01 commented 6 years ago

After initial download, changing name or url (anything but changing the actual model file name) results in no download attempt for the new item. I would expect the initial model_name= to be the “unique” identifier for another download, or something mixed with url, since “resnet-18.model” ay be a common name.

cjolivier01 commented 6 years ago

model download/storage is initiated by: model_name=http://url/model_file.model

for example: resnet-18=http://modelzoo.org/resnet-18.model

if I vary the left-most item and the url, no download attempt is attempted:

resnetXXX-18=http://OTHERZOO.com/resnet-18.model

It appears that the system only checks the 'resnet-18.model' part. Since I can't control model naming on remote sites, my expectation would be something like:

resnet-18_modelzoo=http://modelzoo.org/resnet-18.model and resnet-18_OTHERZOO=http://modelzoo.org/resnet-18.model

My expectation would be that these would be two separate models at least based upon my manual naming ont he left side of this. I did not observe this behavior and that the would be accessed from the model server with the names resnet-18_modelzoo and resnet-18_OTHERZOO.

kevinthesun commented 6 years ago

Fixed in https://github.com/awslabs/portico/pull/80