awslabs / multi-model-server

Multi Model Server is a tool for serving neural net models for inference

Apache License 2.0

998 stars 230 forks source link

Removed redundant/unused code from codebase #860

Closed zak-hassan closed 4 years ago

zak-hassan commented 5 years ago

Before or while filing an issue please feel free to join our slack channel to get in touch with development team, ask questions, find out what's cooking and more!

Issue #, if available:

859

Description of changes:

Removed unused code or imports from the densenet_pytorch example

Testing done:

To run CI tests on your changes refer README.md

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

vdantu commented 5 years ago

@alexwong : Could you review this PR?

alexwong commented 5 years ago

Thanks for contributing! Clean code is always good and I think this is an improvement.

zak-hassan commented 5 years ago

@alexwong Fixed :)

zak-hassan commented 5 years ago

Thanks for the speedy review :)

alexwong commented 5 years ago

Codebuild is currently failing but it's definitely not due to these changes. Will investigate before merging.

vdantu commented 5 years ago

@zmhassan : Thanks for the contribution. Were you able to test that this code works?

vdantu commented 5 years ago

@alexwong : Can this be approved and brought in?

alexwong commented 4 years ago

Sorry, was dealing w/ some other changes recently. Could you just re-trigger the CI and then we can get the changes in?