search

awslabs / multi-model-server

Multi Model Server is a tool for serving neural net models for inference
Apache License 2.0
995 stars 231 forks source link

Update MacOS Java installation guide in Tutorial #900

Closed chenw23 closed 4 years ago

chenw23 commented 4 years ago

Issue #, if available:

Description of changes:

The existing command in the tutorial is deprecated. Please consider updating it to the latest one for avoiding confusion or misleading newcomers.

Currently using the given command will lead to the following errors: Error: caskroom/versions was moved. Tap homebrew/cask-versions instead.

Please refer to https://github.com/Homebrew/homebrew-cask-versions or https://stackoverflow.com/questions/44632292/how-to-install-specific-java-version-using-homebrew.

Testing done:

To run CI tests on your changes refer README.md

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

aaronmarkham commented 4 years ago

I think there's a new requirement from Oracle that you have to sign a license agreement, and download the software from them. This installation path is a bit... convoluted, so it might be better to just say: You need x version of Java (JRE/JDK?) and put that in the prerequisites. Then delete these lines about installing Java via brew.

frankfliu commented 4 years ago

I think there's a new requirement from Oracle that you have to sign a license agreement, and download the software from them. This installation path is a bit... convoluted, so it might be better to just say: You need x version of Java (JRE/JDK?) and put that in the prerequisites. Then delete these lines about installing Java via brew.

We should install openjdk instead.