search

awslabs / oci-add-hooks

Add oci hooks to Docker
Apache License 2.0
60 stars 15 forks source link

Support the new hook types of newer oci spec #9

Closed solarkennedy closed 3 years ago

solarkennedy commented 3 years ago

This adds support for the new hooks that deprecate prestart in newer versions of containerd:

Note that you need to be on container runtime that supports the OCI runtime spec >= v1.0.2 to manipulate these hooks, so I didn't add it into the README, but at least this tool will understand them if present.

Relates to https://github.com/opencontainers/runtime-spec/pull/1008

cc @alban

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

samuelkarp commented 3 years ago

Hi @solarkennedy, thanks for opening this PR! When I look at the diff though, the only things I see changed are .gitignore, a new Go version specified in go.mod, and a newline added in hook.go; were there other changes that you were intending to make that got missed?

solarkennedy commented 3 years ago

Whoops! I was comparing my branch to my fork's master. This was already done in https://github.com/awslabs/oci-add-hooks/pull/7 Nothing to see here :)

samuelkarp commented 3 years ago

Thanks @solarkennedy!