awslabs / palace

3D finite element solver for computational electromagnetics
https://awslabs.github.io/palace/dev
Apache License 2.0
224 stars 50 forks source link

Fix bug for wave ports #192

Closed sebastiangrimberg closed 4 months ago

sebastiangrimberg commented 4 months ago

Note: The re-baselined regression tests for cpw/cpw_wave_uniform and cpw/cpw_wave_adaptive are expected: The quadrature rule fix changes the computed mode shape slightly which affects both the propagation constant as well as the excitation of the model in the driven solve. The changes (all seem to be on the order of a few percent) seem justified in this regard.