search

awslabs / palace

3D finite element solver for computational electromagnetics
https://awslabs.github.io/palace/dev
Apache License 2.0
224 stars 50 forks source link

Add `"Active"` config file field for lumped and wave ports #197

Closed sebastiangrimberg closed 4 months ago

sebastiangrimberg commented 4 months ago

Resolves #171.

In addition, this PR changes field visualization on internal boundaries to always chose the field on the vacuum side (previously, sometimes used vacuum and sometimes used side with lower speed of light).

hughcars commented 4 months ago

Only comment would be to add the documentation for Active in the markdown, but the other branch is merging into this with those changes so probably ok.

sebastiangrimberg commented 4 months ago

Only comment would be to add the documentation for Active in the markdown, but the other branch is merging into this with those changes so probably ok.

Good catch, missed this when rebasing the PRs to reverse their order.