search

awslabs / palace

3D finite element solver for computational electromagnetics
https://awslabs.github.io/palace/dev
Apache License 2.0
224 stars 50 forks source link

Relax requirements for invalid boundary attributes specified for certain boundary conditions #224

Closed sebastiangrimberg closed 2 months ago

sebastiangrimberg commented 3 months ago

Farfield/absorbing boundary conditions and boundary postprocessing can just warn and and ignore invalid boundary attributes. This doesn't pose too much of a risk for users and warnings are sufficiently visible in the log file. This is a usability improvement when copy-pasting large numbers of boundary attributes for models when some domains may not be meshed or may be removed due to no material properties being specified.

sebastiangrimberg commented 2 months ago

@hughcars, do you see any glaring problems with this? Otherwise will merge it in.

sebastiangrimberg commented 2 months ago

Are there other bcs that might have a similar fallback?

Sorry, missed responding to this comment. I don't think so, previous behavior was just for Dirichlet BC and these were adding in the same spirit. Other BCs are more "active" and require parameters which led me to believe that users would/shou;d be more careful in prescribing them to actual boundaries in the model.