awslabs / palace

3D finite element solver for computational electromagnetics
https://awslabs.github.io/palace/dev
Apache License 2.0
224 stars 50 forks source link

Add patch for projection onto NC internal boundaries #236

Closed hughcars closed 1 month ago

hughcars commented 2 months ago

This PR introduces a patch to mfem for nc internal boundaries, where for electrostatics internal boundary conditions would fail to project onto NC refined faces where face dof were present (p > 3). The patch is addressed against mfem at https://github.com/mfem/mfem/pull/4259.

Before: Screenshot 2024-04-22 at 2 56 32 PM

After:

Screenshot 2024-04-23 at 6 14 57 PM
sebastiangrimberg commented 1 month ago

I'd like to include this in v0.13 release. Can you rebase once we merge https://github.com/awslabs/palace/pull/247 and update the Changelog?

sebastiangrimberg commented 1 month ago

Marked as ready now that https://github.com/mfem/mfem/pull/4259 is in review.