awslabs / palace

3D finite element solver for computational electromagnetics
https://awslabs.github.io/palace/dev
Apache License 2.0
224 stars 50 forks source link

Snake case consistency #242

Closed sebastiangrimberg closed 1 month ago

sebastiangrimberg commented 2 months ago

We have slowly moved towards consistent use of snake case across all variable naming, especially in the higher level classes and functions where variable names are longer and more descriptive. Though not explicitly enforced in the developer documentation or in PR reviews, this PR goes through some old code and updates variable names to be match the guidance.

The same change is also made for some output variables, namely the field names in the ParaView visualization files.

One name left unchanged is iodata, which could/should be renamed to io_data. I didn't have particular feelings either way, but if changing it is preferable I can make that change here as well.

Note: Based on https://github.com/awslabs/palace/pull/240