awslabs / palace

3D finite element solver for computational electromagnetics
https://awslabs.github.io/palace/dev
Apache License 2.0
224 stars 50 forks source link

Further improvements to lumped element geometry processing #248

Closed sebastiangrimberg closed 1 month ago

sebastiangrimberg commented 1 month ago

A follow-up to https://github.com/awslabs/palace/pull/246, which removes the integration of the port area to calculate the geometry of uniform and coaxial lumped elements. This step was susceptible to discretization error, in particular for coaxial lumped ports with circular boundaries. These geometric properties can now be calculated directly using the element bounding box/sphere.

This change mandates rebaselining the coaxial regression tests. For the coaxial cable with inner and outer diameters of 1.6383 and 5.461 mm, respectively, the impedance per square for the 50 Ohm coaxial lumped port should be 260.9 Ohm/sq (R = Rs * ln(R_o/R_i) / 2π). The values computed by Palace and used internally for the impedance BC are:

Thus, this PR corrects a previous geometry processing accuracy issue which showed up for coarsely meshed curves. Looking at the port V and I time histories, it looks like the errors were on the order of 1% for this example.