search

awslabs / payload-offloading-java-common-lib-for-aws

Shared library between AWS extended messaging clients to manage payloads larger than their limits.
Apache License 2.0
32 stars 15 forks source link

S3AsyncClient Support #19

Closed richardsmithsfdc closed 6 months ago

richardsmithsfdc commented 1 year ago

Issue #, if available: 17

Description of changes:

This change enables async SQS and S3 client support to be enabled in the Java SQS extended client. I have a companion PR for that repo if this one is accepted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

scottgerring commented 9 months ago

@richardsmithsfdc was glad to discover you've already implemented this!

i've taken it and updated it to the current state of master here - https://github.com/awslabs/payload-offloading-java-common-lib-for-aws/pull/50

kvcmc23 commented 6 months ago

Does the support to AsyncClient has been released?

richardsmithsfdc commented 6 months ago

Does the support to AsyncClient has been released?

It doesn't look like it. @scottgerring made a new PR syncing changes from the latest master at the end of last year, and there has been no movement on that either. I submitted my PR two years ago. It looks like we all have to continue to do what we've been doing, which is to put the async code in our own libraries.

richardsmithsfdc commented 6 months ago

@richardsmithsfdc was glad to discover you've already implemented this!

i've taken it and updated it to the current state of master here - #50

@ziyanli-amazon , since you committed to this repo last year, is anyone there assigned to look at issues and features?

scottgerring commented 6 months ago

Let me see if I can try find someone responsible for this too.

ziyanli-amazon commented 6 months ago

@richardsmithsfdc @scottgerring I will take a look next week after i get offcall.

ziyanli-amazon commented 6 months ago

This PR is merged