search

awslabs / python-deequ

Python API for Deequ
Apache License 2.0
669 stars 131 forks source link

Relaxe python and numpy requirements #122

Closed dyf102 closed 1 year ago

dyf102 commented 1 year ago

Issue #, if available:

Description of changes: Relax the python and numpy requirements to have better backward compability.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

chenliu0831 commented 1 year ago

Hi @dyf102, could you post a test run results with the older environment you want? Could you also post the env details:

You can run those lines: https://github.com/awslabs/python-deequ/blob/master/.github/workflows/base.yml#L34-L39

dyf102 commented 1 year ago

The updated constrains as follow python = ">=3.6.2,<4" numpy = ">=1.14.1"

dyf102 commented 1 year ago

Will the worflow automcatically run the pytest?

chenliu0831 commented 1 year ago

Will the worflow automcatically run the pytest?

Python 3.6 is deprecated and 3.7 is about to deprecate in <3 months. Later version of Numpy does not work with Python 3.7 already. So we decide not to run CI and keep Python 3.7 in legacy mode

chenliu0831 commented 1 year ago

@dyf102 gentle bump did you get chance to post testing results?

chenliu0831 commented 1 year ago

Python 3.6 cannot work with Spark 3.3 - we need to configure CI separately