search

awslabs / python-deequ

Python API for Deequ
Apache License 2.0
669 stars 131 forks source link

Anomaly check config exception #162

Open dinjazelena opened 9 months ago

dinjazelena commented 9 months ago

https://github.com/awslabs/python-deequ/blob/master/pydeequ/verification.py#L190-L192

Hey, i think here should be

if anomalyCheckConfig:
    raise NotImplementedError("anomalyCheckConfigs have not been implemented yet, using default value")

# I think it should be:

if not anomalyCheckConfig:
    raise NotImplementedError("anomalyCheckConfigs have not been implemented yet, using default value")
chenliu0831 commented 9 months ago

anomalyCheckConfig has to be None for now since it's not support today. That's the reason the default is None as well (which does look confusing). I would take this as a feature request to support it though.

dinjazelena commented 9 months ago

So no way to change check level for anomalycheck?

chenliu0831 commented 8 months ago

@dinjazelena not right now until we add the check config implementation