search

awslabs / python-deequ

Python API for Deequ
Apache License 2.0
713 stars 134 forks source link

containsCreditCardNumber analyser constraint doesnt support for JCB credit card #189

Closed kakampassi closed 7 months ago

kakampassi commented 8 months ago

Describe the bug containsCreditCardNumber analyser constraint doesnt support for JCB credit card

To Reproduce // Visa, MasterCard, AMEX, Diners Club val CREDITCARD: Regex = """\b(?:3[47]\d{2}([\ -]?)\d{6}\1\d|(?:(?:4\d|5[1-5]|65)\d{2}|6011)([\ -]?)\d{4}\2\d{4}\2)\d{4}\b""".r

The below two credit card doesnt belong to any of the above CC type. They belong to JCB credit card. 3566002020360505 , 3530111333300000

Expected behavior It should support JCB credit card as well

Reference https://github.com/awslabs/deequ/blob/master/src/main/scala/com/amazon/deequ/analyzers/PatternMatch.scala

kakampassi commented 8 months ago

@chenliu0831 Please share the expected feature delivery date.

chenliu0831 commented 7 months ago

@kakampassi please submit the feature request in Deequ repo.