search

awslabs / python-deequ

Python API for Deequ
Apache License 2.0
676 stars 131 forks source link

hasPattern check is no longer implemented in 0.1.8 (was available in 0.1.7) #71

Closed poolis closed 10 months ago

poolis commented 2 years ago

pydeequ.checks.Check.hasPattern is no longer implemented (method is a no-op):

https://github.com/awslabs/python-deequ/blob/2449f6058548c19300c42c2451a64a2e1af73aa3/pydeequ/checks.py#L555

In tag0.1.7 it was implemented as expected: https://github.com/awslabs/python-deequ/blob/2ee4f70adc009cb264066ce41ee9b610113e1a8f/pydeequ/checks.py#L551

Was it removed for some reason? I realize you can use satisfies to work around the issue but hasPattern is more user friendly. I have no problem creating a PR for the change, just want to make sure there wasn't some particular reason it was removed before spending any time on it. Thanks!

chenliu0831 commented 10 months ago

I just merged https://github.com/awslabs/python-deequ/pull/66 which should address this

chenliu0831 commented 10 months ago

Tracking in https://github.com/awslabs/python-deequ/issues/152.