awslabs / rds-snapshot-tool

The Snapshot Tool for Amazon RDS automates the task of creating manual snapshots, copying them into a different account and a different region, and deleting them after a specified number of days
Apache License 2.0
341 stars 144 forks source link

support china regions #59

Open qqshfox opened 4 years ago

qqshfox commented 4 years ago

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

mrcoronel commented 4 years ago

Hi @qqshfox , thanks for your pull request. Unfortunately, the buckets are already taken so I can't accept. If you'd like, you can change them to snapshots-tool-rds-cn-north-1-official snapshots-tool-rds-cn-northwest-1-official and I'll be happy to merge.

Thanks!

qqshfox commented 4 years ago

These buckets are taken by me. I’ll happy to give them up if you can take these.

Regards, Hanfei


发件人: mrcoronel notifications@github.com 发送时间: 星期四, 二月 13, 2020 19:30 收件人: awslabs/rds-snapshot-tool 抄送: Hanfei Shen; Mention 主题: Re: [awslabs/rds-snapshot-tool] support china regions (#59)

Hi @qqshfoxhttps://github.com/qqshfox , thanks for your pull request. Unfortunately, the buckets are already taken so I can't accept. If you'd like, you can change them to snapshots-tool-rds-cn-north-1-official snapshots-tool-rds-cn-northwest-1-official and I'll be happy to merge.

Thanks!

― You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/awslabs/rds-snapshot-tool/pull/59?email_source=notifications&email_token=AADQHVKO5V57C7C5GBJNB33RCUVN3A5CNFSM4KTZ5QV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELUOXGQ#issuecomment-585690010, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AADQHVJCXBLNC5IGSK6V7DLRCUVN3ANCNFSM4KTZ5QVQ.

mrcoronel commented 4 years ago

I could try to create them again if you delete them from your account. But there is no guarantee someone else will take them

qqshfox commented 4 years ago

Deleted.

mrcoronel commented 4 years ago

Thanks! I've got the buckets in my account now. I'll need to change a few things to upload the lambda code in these buckets, I'll merge the PR once that's ready