awslabs / rds-snapshot-tool

The Snapshot Tool for Amazon RDS automates the task of creating manual snapshots, copying them into a different account and a different region, and deleting them after a specified number of days
Apache License 2.0
341 stars 146 forks source link

Fix issue where setting InstanceNamePattern to ALL_INSTANCES does not… #6

Closed rwarren99 closed 6 years ago

rwarren99 commented 6 years ago

… share any snapshots.

I looked at your code and was setting InstanceNamePattern to ALL_INSTANCES when deploying via CloudFormation. I found that no snapshots got shared. The fix for me was to change the function get_own_snapshots_source in snapshots_tool_utils.py and added "or pattern == 'ALL_INSTANCES'".