awslabs / route53-dynamic-dns-with-lambda

A Dynamic DNS system built with API Gateway, Lambda & Route 53.
Apache License 2.0
486 stars 167 forks source link

Documentation | Invoke URL should explicitly state to remove https:// #15

Closed jwl17330536 closed 6 years ago

jwl17330536 commented 7 years ago

Thanks so much for this! This is awesome and some of the easiest steps to follow I've ever went through.

Unless I missed it, nothing in the documentation state to remove the "https://" from the Invoke URL. I merely went on my way and kept getting a silent failure until I looked around at what was going on. Perhaps add error handling there or update the documentation.

Happy to work on this if you want. Let me know how you want it handled.

seangreathouse commented 7 years ago

Hey thanks John, glad you found this useful. Please correct me if I misunderstood the issue. You do need the https:// to call the API, however in my example bash client implementation, you call the script without the https:// because the script adds it back when it curls the API. What would have helped add clarity for you here? Ultimately I would like to publish this all as a Cloudformation template and deprecate the detailed instructions.

jwl17330536 commented 7 years ago

Your example(s) all show the invoke URL as "12345aaaa.execute-api.us-west-2.amazonaws.com/prod http://12345aaaa.execute-api.us-west-2.amazonaws.com/prod

When one gets their own URL (and like the one that you show) it appears from Amazon as “https://12345aaaa.execute-api.us-west-2.amazonaws.com/prod http://12345aaaa.execute-api.us-west-2.amazonaws.com/prod

If you copy/paste exactly from Amazon then you will end up with the “https://“ prefaced and the script fails silently? Does that make any sense?

On Apr 25, 2017, at 5:30 PM, seangreathouse notifications@github.com wrote:

Hey thanks John, glad you found this useful. Please correct me if I misunderstood the issue. You do need the https:// to call the API, however in my example bash client implementation, you call the script without the https:// because the script adds it back when it curls the API. What would have helped add clarity for you here? Ultimately I would like to publish this all as a Cloudformation template and deprecate the detailed instructions.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/awslabs/route53-dynamic-dns-with-lambda/issues/15#issuecomment-297171027, or mute the thread https://github.com/notifications/unsubscribe-auth/AOjyuCUh7Ruv1Vz_WEt5XnuHMf_a5cltks5rzmYCgaJpZM4NIEsw.

seangreathouse commented 6 years ago

This is fixed in the new bash client. It will take the URL with or without https://