search

awslabs / route53-dynamic-dns-with-lambda

A Dynamic DNS system built with API Gateway, Lambda & Route 53.
Apache License 2.0
486 stars 167 forks source link

Python3: AWS stack creation fails #33

Closed huelsner closed 1 year ago

huelsner commented 4 years ago

When trying to deploy a version of the Python3 branch using the provided yml I get the following error after the 1hr timeout:

Logial ID: setupSourceToS3 Status: CREATE_FAILED Status reason: Custom Resource failed to stabilize in expected time

Any ideas?

seangreathouse commented 4 years ago

That branch was a work in progress. I was working on the Lambda code, but have never tested the full CloudFormation deploy. I apologize for the confusion. I have also started a new position so I'm having some bandwidth issues getting Python3 support out the door. Best, Sean

huelsner commented 4 years ago

Thanks for the clarification. I got triggered by the AWS warning about Python2 support ending by the end of the year. Knowing the situation I will start looking into the issue myself.

seangreathouse commented 4 years ago

I don't think there's much work to do to get the Lambda's compliant. Any PRs will be welcomed. I no longer have access to merge PRs but I'll find someone who does if you are able to contribute.

Thanks again.

huelsner commented 4 years ago

In the end it was adding the binary parameter when opening the zip file previously created. Otherwise reading the file failed with an UTF8 encoding error. The Python3 version now works for me. Pull request has been submitted.

seangreathouse commented 4 years ago

Thanks! I'm working on finding the person who can merge it for us.

huelsner commented 3 years ago

Hi Sean, any success in finding the right person?

masberta commented 1 year ago

Hello, code base has been rewritten, please open a new issue if you encounter similar problems with the new solution. Thanks!