Update yml so that upload of files to S3 works

awslabs / route53-dynamic-dns-with-lambda

A Dynamic DNS system built with API Gateway, Lambda & Route 53.

Apache License 2.0

491 stars 166 forks source link

Update yml so that upload of files to S3 works #34

Closed huelsner closed 1 year ago

huelsner commented 4 years ago

Apparently in Python3 the binary flag is mandatory for reading binary files (in this case the zip file previously created). Creating the Python3 version using CloudFormation now works.

Issue #, if available: 33

Description of changes: Changed parameters for opening the zip file to include the binary flag.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

metalix2 commented 3 years ago

Any update on this getting merged? Python2 deadline is nearing 😨

rrlapointe commented 3 years ago

This should be merged. The Python 2 deadline is in less than a month.

huelsner commented 3 years ago

If I remember correctly, the author no longer works for AWS, so we need to find someone else with merge rights...