awslabs / sagemaker-battlesnake-ai

Starter pack to build an AI for Battlesnake with Amazon Sagemaker more content on wiki:
https://github.com/awslabs/sagemaker-battlesnake-ai/wiki
Apache License 2.0
89 stars 53 forks source link

Address vulnerabilities #45

Closed anrikus closed 2 years ago

anrikus commented 2 years ago

Updated requirements.txt to address vulnerable dependencies.

Captainia commented 2 years ago

How did you test? Will the notebooks still run?

This is fine since the codes here are for reference, but what is the reason of not updating with latest content from code.amazon.com?

jinyoung-lim commented 2 years ago

@Captainia I see! Yeah @anrikus would it be quick enough for you to update with the latest content?

anrikus commented 2 years ago

The solution here are supposed to work on classic notebooks instances and not Sagemaker studio, as such, not keeping this in sync with the code.amazon.com version.

anrikus commented 2 years ago

@jinyoung-lim, the solution should still run as it is picking the artifacts from the prod bucket and not Github, also bypassing the requirements for testing.

anrikus commented 2 years ago

How did you test? Will the notebooks still run?

This version is not in sync with the Studio version for now. The Studio version is being maintained for the time being, the maintainability of the Github solution will be addressed later.