awslabs / sagemaker-debugger

Amazon SageMaker Debugger provides functionality to save tensors during training of machine learning jobs and analyze those tensors
Apache License 2.0
161 stars 83 forks source link

Reduce ZCC Runtimes #315

Open NihalHarish opened 4 years ago

NihalHarish commented 4 years ago

Description of changes:

Style and formatting:

I have run pre-commit install to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 4 years ago

Codecov Report

Merging #315 into master will decrease coverage by 2.80%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
- Coverage   84.36%   81.56%   -2.81%     
==========================================
  Files          86       86              
  Lines        6352     6352              
==========================================
- Hits         5359     5181     -178     
- Misses        993     1171     +178     
Impacted Files Coverage Δ
smdebug/pytorch/__init__.py 0.00% <0.00%> (-100.00%) :arrow_down:
smdebug/pytorch/singleton_utils.py 0.00% <0.00%> (-100.00%) :arrow_down:
smdebug/pytorch/collection.py 0.00% <0.00%> (-90.00%) :arrow_down:
smdebug/pytorch/hook.py 0.00% <0.00%> (-80.33%) :arrow_down:
smdebug/pytorch/utils.py 0.00% <0.00%> (-43.59%) :arrow_down:
smdebug/rules/action/stop_training_action.py 61.53% <0.00%> (-15.39%) :arrow_down:
smdebug/rules/req_tensors.py 79.16% <0.00%> (-11.12%) :arrow_down:
smdebug/core/tfevent/util.py 83.87% <0.00%> (-6.46%) :arrow_down:
smdebug/tensorflow/callable_cache.py 78.26% <0.00%> (-4.35%) :arrow_down:
smdebug/rules/action/action.py 91.83% <0.00%> (-4.09%) :arrow_down:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update edc8499...754d9b6. Read the comment docs.

NihalHarish commented 4 years ago

Leaving this PR open. The performance concern was addressed in

https://github.com/awslabs/sagemaker-debugger/pull/316

vandanavk commented 4 years ago

whats the next step on this pr?