awslabs / sagemaker-debugger

Amazon SageMaker Debugger provides functionality to save tensors during training of machine learning jobs and analyze those tensors
Apache License 2.0
161 stars 83 forks source link

Fixing the nightly build pipelines. Avoid force reinstall of rules package when not necessary #374

Closed leleamol closed 4 years ago

leleamol commented 4 years ago

Description of changes:

This is remaining change to fix the nightly builds in the pipeline. Then script was force reinstalling the rules binary.

Ran the codebuilds for pytorch and xgboost and ensure that they are passing.

pytorch: https://tiny.amazon.com/29lmqkx5/IsenLink xgboost: https://tiny.amazon.com/o6dpquzv/IsenLink

Style and formatting:

I have run pre-commit install to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 4 years ago

Codecov Report

Merging #374 into master will decrease coverage by 2.56%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
- Coverage   85.32%   82.75%   -2.57%     
==========================================
  Files          86       86              
  Lines        6507     6507              
==========================================
- Hits         5552     5385     -167     
- Misses        955     1122     +167     
Impacted Files Coverage Δ
smdebug/tensorflow/utils.py 62.63% <0.00%> (-25.27%) :arrow_down:
smdebug/tensorflow/singleton_utils.py 83.33% <0.00%> (-16.67%) :arrow_down:
smdebug/mxnet/utils.py 59.37% <0.00%> (-15.63%) :arrow_down:
smdebug/tensorflow/keras.py 79.52% <0.00%> (-12.80%) :arrow_down:
smdebug/tensorflow/reductions.py 0.00% <0.00%> (-11.77%) :arrow_down:
smdebug/tensorflow/collection.py 84.53% <0.00%> (-11.35%) :arrow_down:
smdebug/core/utils.py 83.56% <0.00%> (-9.86%) :arrow_down:
smdebug/tensorflow/callable_cache.py 69.56% <0.00%> (-8.70%) :arrow_down:
smdebug/tensorflow/session.py 88.46% <0.00%> (-3.37%) :arrow_down:
smdebug/tensorflow/base_hook.py 76.19% <0.00%> (-2.78%) :arrow_down:
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 06b412d...1cb8754. Read the comment docs.

codecov-io commented 4 years ago

Codecov Report

Merging #374 into master will increase coverage by 0.15%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   85.32%   85.47%   +0.15%     
==========================================
  Files          86       86              
  Lines        6507     6507              
==========================================
+ Hits         5552     5562      +10     
+ Misses        955      945      -10     
Impacted Files Coverage Δ
smdebug/mxnet/utils.py 59.37% <0.00%> (-15.63%) :arrow_down:
smdebug/tensorflow/reductions.py 0.00% <0.00%> (-11.77%) :arrow_down:
smdebug/core/utils.py 83.56% <0.00%> (-9.86%) :arrow_down:
smdebug/tensorflow/base_hook.py 80.55% <0.00%> (+1.58%) :arrow_up:
smdebug/pytorch/hook.py 82.40% <0.00%> (+2.40%) :arrow_up:
smdebug/mxnet/collection.py 76.66% <0.00%> (+3.33%) :arrow_up:
smdebug/rules/action/message_action.py 85.54% <0.00%> (+3.61%) :arrow_up:
smdebug/rules/action/action.py 95.91% <0.00%> (+4.08%) :arrow_up:
smdebug/tensorflow/callable_cache.py 82.60% <0.00%> (+4.34%) :arrow_up:
smdebug/core/tfevent/util.py 100.00% <0.00%> (+8.00%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 06b412d...eb5c44f. Read the comment docs.