awslabs / sagemaker-debugger

Amazon SageMaker Debugger provides functionality to save tensors during training of machine learning jobs and analyze those tensors
Apache License 2.0
161 stars 83 forks source link

returning list instead of dict keys #376

Closed Vikas-kum closed 4 years ago

Vikas-kum commented 4 years ago

fix in return of _get_sm_tj_jobs_with_prefix . This function should return list always.

Description of changes:

Style and formatting:

I have run pre-commit install to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-io commented 4 years ago

Codecov Report

Merging #376 into master will increase coverage by 1.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
+ Coverage   85.47%   86.49%   +1.01%     
==========================================
  Files          86       86              
  Lines        6507     6507              
==========================================
+ Hits         5562     5628      +66     
+ Misses        945      879      -66     
Impacted Files Coverage Δ
smdebug/rules/action/stop_training_action.py 77.41% <100.00%> (ø)
smdebug/trials/trial.py 97.11% <0.00%> (+0.28%) :arrow_up:
smdebug/core/index_reader.py 90.51% <0.00%> (+0.43%) :arrow_up:
smdebug/core/collection_manager.py 93.90% <0.00%> (+1.21%) :arrow_up:
smdebug/core/utils.py 84.97% <0.00%> (+1.40%) :arrow_up:
smdebug/core/access_layer/s3handler.py 70.19% <0.00%> (+1.98%) :arrow_up:
smdebug/core/reductions.py 97.82% <0.00%> (+4.34%) :arrow_up:
smdebug/core/tensor.py 85.08% <0.00%> (+6.04%) :arrow_up:
smdebug/mxnet/collection.py 83.33% <0.00%> (+6.66%) :arrow_up:
smdebug/core/tfrecord/record_reader.py 86.00% <0.00%> (+8.00%) :arrow_up:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f5b06d...303ab4c. Read the comment docs.