search

awslabs / sagemaker-debugger

Amazon SageMaker Debugger provides functionality to save tensors during training of machine learning jobs and analyze those tensors
Apache License 2.0
161 stars 83 forks source link

Regex match bug #408

Closed NihalHarish closed 3 years ago

NihalHarish commented 3 years ago

Description of changes:

Bug Description: For the layers and gradients default collection, even if the user specified an include_regex; the regex logic would be ignored and we'd end up capturing all tensors for that default collection.

Changelog:

Style and formatting:

I have run pre-commit install to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-io commented 3 years ago

Codecov Report

Merging #408 (81a42a9) into master (60b1627) will decrease coverage by 2.06%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
- Coverage   65.69%   63.62%   -2.07%     
==========================================
  Files         161      161              
  Lines       12695    12704       +9     
==========================================
- Hits         8340     8083     -257     
- Misses       4355     4621     +266
Impacted Files Coverage Δ
smdebug/core/hook.py 90.34% <0.00%> (-2.98%) :arrow_down:
smdebug/tensorflow/keras.py 59.01% <0.00%> (-31.08%) :arrow_down:
smdebug/profiler/utils.py 65.43% <0.00%> (-6.80%) :arrow_down:
smdebug/core/singleton_utils.py 79.41% <0.00%> (-5.89%) :arrow_down:
smdebug/core/locations.py 80.55% <0.00%> (-5.56%) :arrow_down:
smdebug/tensorflow/base_hook.py 70.58% <0.00%> (-4.78%) :arrow_down:
smdebug/tensorflow/utils.py 84.28% <0.00%> (-3.34%) :arrow_down:
smdebug/core/access_layer/utils.py 83.33% <0.00%> (-3.34%) :arrow_down:
smdebug/tensorflow/tensor_ref.py 85.48% <0.00%> (-3.23%) :arrow_down:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60b1627...599bf16. Read the comment docs.