search

awslabs / sagemaker-debugger

Amazon SageMaker Debugger provides functionality to save tensors during training of machine learning jobs and analyze those tensors
Apache License 2.0
161 stars 83 forks source link

Remove Spamming Warning Log #435

Closed NihalHarish closed 3 years ago

NihalHarish commented 3 years ago

Description of changes:

Style and formatting:

I have run pre-commit install to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-io commented 3 years ago

Codecov Report

Merging #435 (effe96d) into master (d4dcfc7) will decrease coverage by 14.25%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #435       +/-   ##
===========================================
- Coverage   66.05%   51.79%   -14.26%     
===========================================
  Files         161      161               
  Lines       12704    12709        +5     
===========================================
- Hits         8392     6583     -1809     
- Misses       4312     6126     +1814
Impacted Files Coverage Δ
smdebug/tensorflow/keras.py 2.21% <0.00%> (-87.95%) :arrow_down:
smdebug/tensorflow/__init__.py 0.00% <0.00%> (-100.00%) :arrow_down:
smdebug/tensorflow/constants.py 0.00% <0.00%> (-100.00%) :arrow_down:
smdebug/tensorflow/singleton_utils.py 0.00% <0.00%> (-100.00%) :arrow_down:
smdebug/tensorflow/collection.py 0.00% <0.00%> (-95.88%) :arrow_down:
smdebug/tensorflow/session.py 0.00% <0.00%> (-91.83%) :arrow_down:
smdebug/tensorflow/tensor_ref.py 0.00% <0.00%> (-88.71%) :arrow_down:
smdebug/tensorflow/utils.py 0.00% <0.00%> (-87.62%) :arrow_down:
smdebug/tensorflow/base_hook.py 0.00% <0.00%> (-83.83%) :arrow_down:
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4dcfc7...effe96d. Read the comment docs.

ndodda-amazon commented 3 years ago

If the issue is that this log is being spammed, shouldn't we ensure that this message only gets logged once or a fixed number of times?

NihalHarish commented 3 years ago

If the issue is that this log is being spammed, shouldn't we ensure that this message only gets logged once or a fixed number of times?

Good thought. Let's move the log to a different LOC entirely.