awslabs / sagemaker-debugger

Amazon SageMaker Debugger provides functionality to save tensors during training of machine learning jobs and analyze those tensors
Apache License 2.0
161 stars 83 forks source link

Fix bug for actions and improve design #448

Closed ndodda-amazon closed 3 years ago

ndodda-amazon commented 3 years ago

Description of changes:

Two major changes:

Style and formatting:

I have run pre-commit install to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-io commented 3 years ago

Codecov Report

Merging #448 (a79560d) into master (64fb95f) will increase coverage by 0.09%. The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   65.73%   65.83%   +0.09%     
==========================================
  Files         161      161              
  Lines       12749    12747       -2     
==========================================
+ Hits         8381     8392      +11     
+ Misses       4368     4355      -13     
Impacted Files Coverage Δ
smdebug/rules/action/stop_training_action.py 54.68% <50.00%> (+0.14%) :arrow_up:
smdebug/rules/action/action.py 91.83% <100.00%> (ø)
smdebug/rules/action/message_action.py 81.92% <100.00%> (ø)
smdebug/rules/rule.py 84.84% <100.00%> (ø)
smdebug/core/reduction_config.py 88.31% <0.00%> (-2.60%) :arrow_down:
smdebug/core/save_config.py 88.80% <0.00%> (+0.79%) :arrow_up:
smdebug/core/writer.py 90.09% <0.00%> (+4.50%) :arrow_up:
smdebug/core/logger.py 76.38% <0.00%> (+5.55%) :arrow_up:
smdebug/core/tfevent/summary.py 88.13% <0.00%> (+6.77%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 64fb95f...a79560d. Read the comment docs.