awslabs / sagemaker-debugger

Amazon SageMaker Debugger provides functionality to save tensors during training of machine learning jobs and analyze those tensors
Apache License 2.0
161 stars 83 forks source link

Install Protoc With setup.py #513

Closed NihalHarish closed 3 years ago

NihalHarish commented 3 years ago

Description of changes:

Style and formatting:

I have run pre-commit install to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 3 years ago

Codecov Report

Merging #513 (40bba75) into master (9e790c4) will decrease coverage by 1.97%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
- Coverage   76.29%   74.31%   -1.98%     
==========================================
  Files         126      117       -9     
  Lines       10873    10584     -289     
==========================================
- Hits         8296     7866     -430     
- Misses       2577     2718     +141     
Impacted Files Coverage Δ
compile_protobuf.py 0.00% <0.00%> (ø)
smdebug/pytorch/utils.py 45.23% <0.00%> (-35.72%) :arrow_down:
smdebug/rules/action/message_action.py 81.92% <0.00%> (-15.67%) :arrow_down:
smdebug/profiler/tf_profiler_parser.py 54.54% <0.00%> (-11.58%) :arrow_down:
smdebug/core/logger.py 70.83% <0.00%> (-8.34%) :arrow_down:
smdebug/rules/action/stop_training_action.py 54.68% <0.00%> (-7.82%) :arrow_down:
smdebug/core/reduction_config.py 88.31% <0.00%> (-7.80%) :arrow_down:
smdebug/mxnet/collection.py 73.33% <0.00%> (-6.67%) :arrow_down:
smdebug/mxnet/utils.py 59.37% <0.00%> (-6.25%) :arrow_down:
smdebug/core/singleton_utils.py 79.41% <0.00%> (-5.89%) :arrow_down:
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e790c4...40bba75. Read the comment docs.

NihalHarish commented 3 years ago

Remove the protobuf installation script and remove this line from all of the buildspecs.

Also, talk to @mchoi8739 in order to sanity check whether a RTD build will succeed with these changes. Even though this is in Python, the changes are a high level wrapper over shell commands which may not be allowed in the build environment.

The RTD build seems to be working fine with this change. I will go ahead and update all the buildspec files.