search

awslabs / sagemaker-debugger

Amazon SageMaker Debugger provides functionality to save tensors during training of machine learning jobs and analyze those tensors
Apache License 2.0
161 stars 83 forks source link

Fix papermill version for tf2.5 build #533

Closed mariumof closed 2 years ago

mariumof commented 2 years ago

Description of changes:

Style and formatting:

I have run pre-commit install && pre-commit run --all-files to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ztlevi commented 2 years ago

The file you changed is buildspec_tensorflow_2_3.yml. How is this related with 2.5 build?

codecov-commenter commented 2 years ago

Codecov Report

Merging #533 (2fd901b) into master (efa0041) will decrease coverage by 6.74%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
- Coverage   75.31%   68.56%   -6.75%     
==========================================
  Files         127      117      -10     
  Lines       11117    10591     -526     
==========================================
- Hits         8373     7262    -1111     
- Misses       2744     3329     +585
Impacted Files Coverage Δ
smdebug/mxnet/__init__.py 0.00% <0.00%> (-100.00%) :arrow_down:
smdebug/mxnet/singleton_utils.py 0.00% <0.00%> (-100.00%) :arrow_down:
smdebug/mxnet/hook.py 0.00% <0.00%> (-83.34%) :arrow_down:
smdebug/mxnet/collection.py 0.00% <0.00%> (-76.67%) :arrow_down:
smdebug/rules/action/message_action.py 13.25% <0.00%> (-72.29%) :arrow_down:
smdebug/rules/action/action.py 30.61% <0.00%> (-61.23%) :arrow_down:
...iler/analysis/utils/pytorch_dataloader_analysis.py 0.00% <0.00%> (-44.95%) :arrow_down:
smdebug/rules/action/stop_training_action.py 12.50% <0.00%> (-42.19%) :arrow_down:
smdebug/pytorch/utils.py 46.51% <0.00%> (-37.21%) :arrow_down:
smdebug/core/modes.py 55.00% <0.00%> (-30.00%) :arrow_down:
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update efa0041...2fd901b. Read the comment docs.

mariumof commented 2 years ago

It is the only tf2 buildspec use by our tests. The goal is to get "TF2_old" running, and create new ones when we move to 2.7 and 2.8.