search

awslabs / sagemaker-debugger

Amazon SageMaker Debugger provides functionality to save tensors during training of machine learning jobs and analyze those tensors
Apache License 2.0
158 stars 82 forks source link

skip trace.json file reader for tf 2.11 and above since it's no longe… #636

Closed ztlevi closed 1 year ago

ztlevi commented 1 year ago

Description of changes:

TF 2.11 no longer have trace.json.gz file available. They merged all data to xxx-.xplane.pb file. This PR disables TF framework profiler support for TF 2.11 and above to unblock the AWS TF release.

Style and formatting:

I have run pre-commit install && pre-commit run --all-files to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

yl-to commented 1 year ago

If profiler team's decision is to disable the failing tests, I would suggest @pytest.mark.skipif before the pytest func def

ztlevi commented 1 year ago

Pushed an update for your comments @yl-to

yl-to commented 1 year ago

@ztlevi So profiler team's decision is to skip these tests for tensorflow 2.11, please confirm after you tested it. I will approve the PR once get confirmation.

ztlevi commented 1 year ago

Yes, I confirm tests passes.