search

awslabs / sagemaker-debugger

Amazon SageMaker Debugger provides functionality to save tensors during training of machine learning jobs and analyze those tensors
Apache License 2.0
158 stars 82 forks source link

[WIP] [Draft] First cut at adding new XGBoost callback hook. #647

Closed matherit closed 1 year ago

matherit commented 1 year ago

Description of changes:

Add new XGBoost hook for new XGBoost callback.

Style and formatting:

I have run pre-commit install && pre-commit run --all-files to ensure that auto-formatting happens with every commit.

Issue number, if available

https://github.com/awslabs/sagemaker-debugger/issues/616

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

yl-to commented 1 year ago

hi @matherit, it is hard to read the diff between your commit and the old hook code. Is there anyway for us to easily figure out what has been changed?

matherit commented 1 year ago

Hi @yl-to, I recommend using GitHub's hide whitespace functionality.

This should make it slightly easier to read. Effectively, I had to put the old hook class inside an if statement. Once you hide whitespace changes, the diffs for that class should largely disappear (minus linting changes that applied from running pre-commit).

From there, the rest of the diff should just show the new class I added/packages to support this functionality.

Thanks for the review!

yl-to commented 1 year ago

Closing this one because we have a new PR merged: https://github.com/awslabs/sagemaker-debugger/pull/648, thanks @matherit for creating this.