awslabs / sbt-aws

SaaS Builder Toolkit for AWS is a developer toolkit to implement SaaS best practices and increase developer velocity.
Apache License 2.0
90 stars 16 forks source link

fix: Fix for 19 #21

Closed tobuck-aws closed 2 months ago

tobuck-aws commented 3 months ago

Now explicitly creates the IAM Role allowing APIGW to publish to CloudWatch. Customers can opt out by passing the disableAPILogging property to the ControlPlane props

Issue # 19

Closes #19

Reason for this change

Deployment into a fresh account fails without this change. Now creates the rest API construct with a flag to explicitly create the IAM Role that allows API GW to push to CloudWatch.

Description of changes

Added a new field to the ControlPlaneProps called disableAPILogging. It's optional with a default of false. Also modified docs to surface this change.

Description of how you validated changes

Wrote unit tests to validate the synthed template with and without the flag.

Checklist


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.