awslabs / sbt-aws

SaaS Builder Toolkit for AWS is a developer toolkit to implement SaaS best practices and increase developer velocity.
Apache License 2.0
90 stars 16 forks source link

Control plane stack: unable to delete control plane stack when auth custom resouce is not successfully completed #28

Open ujwalbukka opened 2 months ago

ujwalbukka commented 2 months ago

Describe the bug

When you deploy a control plane stack which uses cognito-auth component and if deployment fails due to error in auth custom resource then if you delete control plane stack it is failing. It is failing because the auth custom resource is getting userpoolId with assumption that user pool will be successfully created all the time.

Expected Behavior

When you delete the control plane stack it should delete whole stack

Current Behavior

Currently, when you deploy a control plane stack which uses cognito-auth component and if deployment fails due to error in auth custom resource then if you delete control plane stack it is failing.

Reproduction Steps

Deploy a control plane stack which uses cognito-auth component with an email address without domain name, the deployment will fail and then try to delete the stack.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.123

Framework Version

No response

Node.js Version

18

OS

Linux

Language

TypeScript

Language Version

No response

Other information

No response