awslabs / sbt-aws

SaaS Builder Toolkit for AWS is a developer toolkit to implement SaaS best practices and increase developer velocity.
Apache License 2.0
90 stars 16 forks source link

fix: event manager cyclic dep #47

Closed suhussai closed 4 weeks ago

suhussai commented 1 month ago

Issue # (if applicable)

Closes #.

Reason for this change

This fixes a bug where the addTargetToEvent(...) function was causing the EventManager stack to be dependent on stacks that used that function.

Description of changes

Instead of creating the rule in the EventManager stack, this change now creates the rule in the calling stack.

Description of how you validated changes

Added lots of tests!

Checklist


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.