search

awslabs / seed-farmer

Seed-Farmer is an orchestration tool that works with AWS CodeSeeder and acts as an orchestration tool modeled after GitOps deployments. It has a CommandLine Interface based in Python, leverages modular code deployments defined by declarative manifests, and includes change detection and deployment optimization.
https://seed-farmer.readthedocs.io/en/latest/
Apache License 2.0
43 stars 15 forks source link

chore: add constraint to resolution of requirements-dev.txt #622

Closed LeonLuttenberger closed 1 month ago

LeonLuttenberger commented 1 month ago

Description of changes: Our requirements-dev.txt resolution doesn't take into account our production dependencies.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

LeonLuttenberger commented 1 month ago

I am not sure what the benefit of the PR is (just looking for a reason to do this....not opposed to it otherwise)

Mainly just to keep the requirements consistent. A minor concern is that in our workflow, we first install from requirement.txt and then from requirements-dev.txt. In the latter, we have outdated versions of certain packages that overlap. So our workflows end up with outdated versions of certain packages, instead of testing on the one we specify in requirement.txt. Dependabot doesn't seem to keep this in line either, although that could change now that the pip-compile command includes the constraints argument.

This, however, is quite a minor concern. The main thing is just keep our dependencies clean and consistent.

dgraeber commented 1 month ago

I am not sure what the benefit of the PR is (just looking for a reason to do this....not opposed to it otherwise)

Mainly just to keep the requirements consistent. A minor concern is that in our workflow, we first install from requirement.txt and then from requirements-dev.txt. In the latter, we have outdated versions of certain packages that overlap. So our workflows end up with outdated versions of certain packages, instead of testing on the one we specify in requirement.txt. Dependabot doesn't seem to keep this in line either, although that could change now that the pip-compile command includes the constraints argument.

This, however, is quite a minor concern. The main thing is just keep our dependencies clean and consistent.

Ok...just remove the change to the docs/requirements-docs.txt -- that is really only for readthedocs. I like this change for the requirments-dev.txt though....good catch! I will look to remove the sphinx references from the requirements-dev.txt also...that is no longer needed (I believe)